Return chainable iterator after QueryResult:without()
#90
Conversation
…chetype-negation
…chetype-negation
|
Case "QueryRework" is the changes to World's query reflected in the PR. Case "Without" is a separate change that does archetype negation for making more narrow subsets of queries #91 . 203 components, 3 archetypes. Looped a query that implements When not using |
| @@ -7,6 +7,8 @@ local assertValidComponent = Component.assertValidComponent | |||
| local archetypeOf = archetypeModule.archetypeOf | |||
| local areArchetypesCompatible = archetypeModule.areArchetypesCompatible | |||
|
|
|||
| local QueryResult = require(script.Parent.query) | |||
There was a problem hiding this comment.
Any reason why the file was named "query" instead of "QueryResult"?
There was a problem hiding this comment.
Mostly because I am conflicted on what to name. I would much prefer calling the file query, but that might mean we have to rename the struct to query as well which I am not sure how I feel about that yet.
What do you suggest?
|
Can we get this linked to an issue that explains what the PR is solving to keep that documented for the future? |
I have now edited the comment to link the relevant issue |
This PR resolves #85.
At initial commit, it passes every test. No regressions and it also works well for the intended use case of chaining with
snapshotorview.However, the code is just glued together and will require quite a bit of polishing before I am confident in shipping this out. The code changes are the minimum steps I took to ensure it passed the tests. And I would like to make sure this code is good enough before I am confident in having it reviewed.
List of things to address first
TODO
Should rework the
QueryResultstruct. It is currently a pretty big struct of data comparatively to what it was before due to it now using methods forexpandandnextinstead of closures and consequently had to store every external variable to be reusable.Should return a NOOP query when there's no compatible archetypes.
Fix organization and comments. Things are a complete mess here due to the fact I had moved around a bunch of things in order to pan the code.