This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
Return chainable iterator after QueryResult:without()
#90
Open
Ukendio
wants to merge
45
commits into
main
Choose a base branch
from
query-iter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
9a84577
Add check for config
Ukendio 89c3f2c
Prototyped implementation
Ukendio 3b8d5d7
Remove whitspace
Ukendio 28e1c9e
Added unit tests
Ukendio 7a93fd7
Preserve order of query traversal
Ukendio a46a97a
Merge branch 'main' of https://github.com/evaera/matter into views
Ukendio aa3d0f4
Adding comments
Ukendio 0a2f6df
Merge branch 'main' of https://github.com/evaera/matter into views
Ukendio 4868ba6
Remove entity param from view
Ukendio 7f67d1d
Oops.
Ukendio e70a590
Add "_" to unused variables
Ukendio 84e1c36
Change otherRoot name in tests
Ukendio 79822a7
Merge branch 'main' of https://github.com/evaera/matter into views
Ukendio 817d1df
Put keys in a linked list
Ukendio e7889b9
Add checks for views:get()
Ukendio 09bd251
Initial Commit
Ukendio ad24560
iterate self._filter instead of entityData
Ukendio ebb1f85
Create a NOOP
Ukendio 03a31b5
Remove unused function
Ukendio e0ed459
Moved functions under corresponding comments
Ukendio bdae1c4
Initial commit
Ukendio fe4ec1d
Expand should be a closure for inlining
Ukendio 0c97ff7
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
Ukendio fad7489
Make :_next into a closure instead
Ukendio 4e9eecf
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
Ukendio a7fe37a
remove topoRuntime import
Ukendio 1cc5144
Make struct smaller
Ukendio ac1d737
Merge branch 'query-iter' of https://github.com/evaera/matter into ar…
Ukendio a53ce69
Change split to ||
Ukendio ef5d8fe
Merge branch 'views' of https://github.com/evaera/matter into archety…
Ukendio 4e9a28b
Moving back some of the query logic
Ukendio c744828
Return static noopQuery
Ukendio e794dd6
Port changes from archetype negation branch
Ukendio cc73650
Initial commit
Ukendio 70d74c9
Revert "Initial commit"
Ukendio 2ae303a
Revert "Revert "Initial commit""
Ukendio 9cd23e5
Revert "Port changes from archetype negation branch"
Ukendio 5009e3b
Revert "Revert "Port changes from archetype negation branch""
Ukendio d7aecf8
Revert "Initial commit"
Ukendio d605f67
Iterable NOOP
Ukendio aac0f7c
noop:without returns noop
Ukendio 7f7e8e1
Return self
Ukendio 87e0cac
Update storage index on empty storage
Ukendio c8e89d7
Merge branch 'main' of https://github.com/evaera/matter into query-iter
Ukendio 5c3a342
Separate changes from archetype-negation
Ukendio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the file was named "query" instead of "QueryResult"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly because I am conflicted on what to name. I would much prefer calling the file query, but that might mean we have to rename the struct to query as well which I am not sure how I feel about that yet.
What do you suggest?