-
-
Notifications
You must be signed in to change notification settings - Fork 833
Loadpoint: rename chargeCurrent to offeredCurrent (BC) #20457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wenn wir das machen dann sollte es komplett sein. Keine doppelten Namen. |
Der UI Change ist überschaubar, soll ich den hier mit rein machen damit wirs sauber haben? |
Ja bitte- ganz oder gar nicht. |
Auch das Logging muss mit angepasst werden. |
@premultiply wozu brauchen wir
|
fyi @marq24 |
UI ist angepasst und das publishing des alten Wert ( |
so I just 'invent' key_alias - so now I can get the value by two different keys - in HA the name will be still the old one... |
…add the new name as alias... evcc-io/evcc#20457 chargeCurrent -> offeredCurrent
The option is to remap the name So the name would stay but the meaning would slightly differ from before. I think this would not break anything in most cases as it would show correctly what was just suggested before. |
I’d rather remove the existing key and accept the breaking change. |
I am totally fine with that: your project -> your rules :-D |
LGTM? |
The name
chargeCurrent
at the loadpoint is confusing because, unlikechargeCurrents
andchargePower
, it is not a measured value but the setpoint value that is sent to the charger.This PR therefore changes its name to
offeredCurrent
.For the API exports, the old export name will also remain for the time being, but will be considered deprecated.
/cc @andig @naltatis @mfuchs1984
TODO
lp.chargeCurrent
as "max(lp.chargeCurrents[])": maximum measured charge current for better API compatibility (non-BC)Out of scope