Feat/add default context and domain #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Last time we've added UNIQUE constraint for kanta, for prevents duplicate entrty.
https://3.basecamp.com/5773253/buckets/36965478/card_tables/cards/7519531566#__recording_7562390811
but applying multiple constraints causes performance down (and it might causes unexpected behaviours), hence in this PR I added logic to register
defaultcontext if it's unspecified in po files.You can test from here: https://nexus-staging-2216d6ee.fly.dev/kanta/dashboard
FYI
This feature is already approved in origin, but not merged yet.
curiosum-dev#69