Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage #6978

Merged
merged 86 commits into from
Oct 12, 2023
Merged

Stage #6978

merged 86 commits into from
Oct 12, 2023

Conversation

evereq
Copy link
Member

@evereq evereq commented Oct 12, 2023

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


adkif and others added 30 commits October 5, 2023 14:21
…put of login and register forms, add RegEx patter to password input in both forms (login, register) to warn user not to start his password with space, add new login validation message and translate it to the other langs, trim the email value in (login, register, rememberMe) Nebular strategy functions
Gramosx and others added 26 commits October 10, 2023 13:20
…al-request

Seeder for default approval req added
feat: add today duration attribute to task statistics
@gitguardian
Copy link

gitguardian bot commented Oct 12, 2023

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7421875 Google API Key a029701 .deploy/k8s/k8s-manifest.civo.prod.yaml View secret
7421875 Google API Key e913ac3 .deploy/k8s/k8s-manifest.civo.prod.yaml View secret
7421875 Google API Key e913ac3 .deploy/k8s/k8s-manifest.civo.stage.yaml View secret
7421875 Google API Key a029701 .deploy/k8s/k8s-manifest.civo.stage.yaml View secret
7421875 Google API Key b3de071 .deploy/k8s/k8s-manifest.civo.stage.yaml View secret
7421875 Google API Key b3de071 .deploy/k8s/k8s-manifest.civo.prod.yaml View secret
7421875 Google API Key d09325e .deploy/k8s/k8s-manifest.civo.stage.yaml View secret
7421875 Google API Key d09325e .deploy/k8s/k8s-manifest.civo.prod.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ adkif
✅ rahul-rocket
✅ coderNadir
✅ Gramosx
✅ evereq
❌ BM-Nadir


BM-Nadir seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@evereq evereq merged commit 97eef73 into stage-apps Oct 12, 2023
@nx-cloud
Copy link

nx-cloud bot commented Oct 12, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 866dabf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx serve api -c=production --prod

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants