Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage #7487

Merged
merged 25 commits into from
Feb 1, 2024
Merged

Stage #7487

merged 25 commits into from
Feb 1, 2024

Conversation

evereq
Copy link
Member

@evereq evereq commented Feb 1, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


adkif and others added 25 commits January 28, 2024 21:55
[Fix]  Escape Query Parameters for pagination
Added IServerFactory interface with createServer method for SSL configuration, as well as SslFactory class implementation. Also, updated SSL component with new button functionality for SSL checking and hiding. Introduces better SSL configuration and management. No associated issues.
Restructured server process initialization for improved error handling and added error logging in the UI server. Extracted server process creation and preparation to separate factory classes. This enhances code organization and maintainability. Introduced a new `ServerManager` class to handle server processes.
Add a new SSL test port and refactor default UI host to handle Windows platform.
Add a new Timeout decorator to provide method timeout functionality, allowing methods to specify a maximum duration for execution. This enhances control over method execution duration and improves error handling. This addresses the need for robust timeout handling in certain asynchronous operations.
To facilitate SSL configuration, added ISslFactory interface with createSslConfig method for IProxyConfig. This change enhances SSL configuration flexibility and reusability across different modules.
Added new files for creating child processes and implementing an observer pattern for server utilities, enabling efficient management of child processes and event notifications. Improves modularity and code organization.
- Refactored ReverseProxy and ReverseUiProxy to inherit from a new SecuredProxy class in order to consolidate and simplify SSL configuration and server setup. The new ServerFactory class was also added to encapsulate HTTPS server creation logic. These changes provide a more modular and maintainable structure for the server handling.
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 6.9.7 to 6.9.9.
- [Release notes](https://github.com/nodemailer/nodemailer/releases)
- [Changelog](https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md)
- [Commits](nodemailer/nodemailer@v6.9.7...v6.9.9)

---
updated-dependencies:
- dependency-name: nodemailer
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…ler-6.9.9

chore(deps): bump nodemailer from 6.9.7 to 6.9.9
Introduce new classes for API and UI services to encapsulate server management logic, allowing easy starting, stopping, and restarting of the services. Each class includes methods to handle service-specific configuration and error handling. This change sets up a foundation for effectively managing the server tasks.

Fixes #7456
Consolidate server instantiation logic into DesktopServerFactory for better organization and maintenance. Introduce DesktopServer class with start, stop, and restart methods to manage server state. Utilize Observer pattern to notify server state changes. Provides a clearer and more centralized approach to server management.
Consolidate server configuration instantiation and streamline server
initialization. Introduce a new DesktopServer class and align server
startup logic for clarity and maintainability.
Use restart flag to provide better feedback when server restarts. Ensure
ChangeDetectorRef detects changes to update UI accordingly.
Handled potential null values for 'arg.type' and 'arg.message' to prevent errors and ensure appropriate toastr message display. This change enhances the robustness of the 'showAlert' method.
@CLAassistant
Copy link

CLAassistant commented Feb 1, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ adkif
✅ evereq
✅ rahul-rocket
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@evereq evereq merged commit 4e053b4 into stage-apps Feb 1, 2024
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants