Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/recoil to jotai #3037

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Refactor/recoil to jotai #3037

merged 6 commits into from
Sep 20, 2024

Conversation

NdekoCode
Copy link
Contributor

Refactor/recoil to jotai

Please include a summary of the changes and the related issue.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Current screenshots

Please add here videos or images of previous status

@NdekoCode NdekoCode requested a review from Cedric921 September 18, 2024 13:31
@NdekoCode NdekoCode force-pushed the refactor/recoil-to-jotai branch from abc5fbf to 63734ac Compare September 18, 2024 13:40
Copy link

socket-security bot commented Sep 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@NdekoCode NdekoCode requested a review from evereq September 18, 2024 14:36
@NdekoCode NdekoCode marked this pull request as ready for review September 18, 2024 14:37
@NdekoCode NdekoCode linked an issue Sep 18, 2024 that may be closed by this pull request
@NdekoCode NdekoCode added enhancement New feature or request WEB Web app Improvement Improvement labels Sep 18, 2024
@NdekoCode NdekoCode self-assigned this Sep 18, 2024
@Cedric921
Copy link
Contributor

I'm reviewing this PR

@evereq
Copy link
Member

evereq commented Sep 19, 2024

@NdekoCode can you VERY carefully please fix merge conflicts?

@NdekoCode NdekoCode force-pushed the refactor/recoil-to-jotai branch from 63734ac to 8b56dde Compare September 19, 2024 18:04
@evereq
Copy link
Member

evereq commented Sep 19, 2024

@NdekoCode sorry, can you do one more time fix of merge conflict?
@Cedric921 did you reviewed PR?

@NdekoCode NdekoCode force-pushed the refactor/recoil-to-jotai branch from 8b56dde to d5a0e7c Compare September 19, 2024 20:19
@NdekoCode
Copy link
Contributor Author

NdekoCode commented Sep 19, 2024

Already done sir @evereq, please @Cedric921, when you have time, try to see the PR again

apps/web/package.json Outdated Show resolved Hide resolved
Copy link

Report too large to display inline

View full report↗︎

@NdekoCode NdekoCode requested a review from evereq September 20, 2024 14:49
@evereq evereq merged commit 93df916 into develop Sep 20, 2024
13 checks passed
@evereq evereq deleted the refactor/recoil-to-jotai branch September 20, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Improvement Improvement WEB Web app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] State management | replacing Recoil to Jotail
3 participants