Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user can add tasks for today / tomorrow plan from 'See plan' modal #3087

Conversation

CREDO23
Copy link
Contributor

@CREDO23 CREDO23 commented Sep 30, 2024

Description

This PR fixes #3028

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Current screenshots

Loom

@CREDO23 CREDO23 added WEB Web app Improvement Improvement Ever Teams labels Sep 30, 2024
@CREDO23 CREDO23 self-assigned this Sep 30, 2024
@CREDO23 CREDO23 marked this pull request as draft September 30, 2024 21:09
@CREDO23 CREDO23 marked this pull request as ready for review September 30, 2024 23:57
@CREDO23 CREDO23 requested review from evereq and Cedric921 September 30, 2024 23:57
@CREDO23 CREDO23 linked an issue Oct 1, 2024 that may be closed by this pull request
employeeId: user?.employee.id,
organizationId: user?.employee.organizationId
});
if (plan) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREDO23 not a good code, why you can't just create var like "let somedate" and set value of it depending on those if statements and below just do one call to

await createDailyPlan({
						workTimePlanned: 0,
						taskId: task.id,
						date: someday, <------
						status: DailyPlanStatusEnum.OPEN,
						tenantId: user?.tenantId ?? '',
						employeeId: user?.employee.id,
						organizationId: user?.employee.organizationId
					});

This is basic, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREDO23 I am merging for now, please improve that in another PR etc

@evereq evereq merged commit 46e01fd into 3007-improvement-see-plan--add-ability-to-createedit-plan Oct 1, 2024
11 checks passed
@evereq evereq deleted the 3028-improvement-see-plan--ability-to-add-task-to-empty-plan branch October 1, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] 'See Plan' | ability to add task to Empty plan
2 participants