Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/pre release #3210

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add/pre release #3210

merged 2 commits into from
Oct 30, 2024

Conversation

Sergemuhundu
Copy link
Collaborator

@Sergemuhundu Sergemuhundu commented Oct 30, 2024

Description

Please include a summary of the changes and the related issue.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

Current screenshots

Please add here videos or images of previous status

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced new workflows for automating the build, deployment, and publishing processes for both Android and iOS applications.
    • Added an "internal" build and submission configuration for Android and iOS in the app settings.
  • Improvements

    • Enhanced existing workflows to utilize a production profile for builds and submissions, ensuring alignment with production environment settings.
    • Updated release stage workflow to recognize the apps-stage branch for version bumps and tagging.

These changes streamline the deployment process and improve the overall efficiency of app management.

@Sergemuhundu Sergemuhundu self-assigned this Oct 30, 2024
Copy link
Contributor

coderabbitai bot commented Oct 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces modifications to existing GitHub Actions workflows for building, deploying, and publishing Android and iOS mobile applications. Key changes include the addition of a --profile production flag to EAS commands in the Android and iOS workflow files. New workflows for staging deployments on both platforms are also introduced. Additionally, the release stage workflow is updated to recognize the apps-stage branch for versioning. An "internal" configuration for builds and submissions is added to the eas.json file for both platforms.

Changes

File Path Change Summary
.github/workflows/mobile.apps.android.yml Added --profile production flag to eas build and eas submit commands.
.github/workflows/mobile.apps.ios.yml Added --profile production flag to eas build, eas update, and eas submit commands.
.github/workflows/mobile.apps.stage.android.yml Introduced a new workflow for staging Android app builds and deployments, triggered on apps-stage branch.
.github/workflows/mobile.apps.stage.ios.yml Introduced a new workflow for staging iOS app builds and deployments, triggered on apps-stage branch.
.github/workflows/release.stage.yml Updated release_branches to include apps-stage.
apps/mobile/eas.json Added "internal" build and submission configurations for both Android and iOS platforms.

Possibly related PRs

  • Feat/add env vars #3160: The changes in this PR involve the addition of environment variables EXPO_PROJECT_PACKAGE_NAME and EXPO_PROJECT_IOS_BUNDLE_IDENTIFIER, which are directly related to the modifications made in the main PR that also includes these environment variables in the Android and iOS workflow files.
  • Add ios credentials #3207: This PR modifies the apps/mobile/eas.json file to include new properties for iOS submission, which aligns with the main PR's focus on enhancing the build and submission processes for mobile applications.

Suggested reviewers

  • evereq

🐇 In the fields where we play,
New workflows hop in, hooray!
With profiles set for production,
Our builds now run with less obstruction.
From Android to iOS, we glide,
To the App Store, we take pride! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Sergemuhundu Sergemuhundu merged commit d0c7e26 into develop Oct 30, 2024
11 of 13 checks passed
@Sergemuhundu Sergemuhundu deleted the add/pre-release branch October 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant