DEVPROD-13969 Remove s3.push and s3.pull #8637
Conversation
| @@ -70,9 +70,6 @@ type attachResults struct { | |||
| func attachResultsFactory() Command { return &attachResults{} } | |||
| func (c *attachResults) Name() string { return evergreen.AttachResultsCommandName } | |||
|
|
|||
| // ParseParams decodes the S3 push command parameters that are | |||
There was a problem hiding this comment.
could we keep this comment and just reword for attach results?
There was a problem hiding this comment.
I was cleaning up the comments since only these commands document this function. I'm okay with documenting it but do you want me to add it to all the other commands?
| @@ -100,7 +100,6 @@ type s3Loc struct { | |||
| func s3CopyFactory() Command { return &s3copy{} } | |||
| func (c *s3copy) Name() string { return "s3Copy.copy" } | |||
|
|
|||
| // ParseParams decodes the S3 push command parameters | |||
| @@ -35,10 +35,6 @@ | |||
| "admins": ["annie.black"], | |||
There was a problem hiding this comment.
didn't know i was in the codebase this much LOL
| // If the user requested task sync in their patch, it should match at least | ||
| // one valid task in a build variant. | ||
| if len(patchDoc.SyncAtEndOpts.VariantsTasks) == 0 { | ||
| j.gitHubError = NoSyncTasksOrVariants |
There was a problem hiding this comment.
we can remove NoSyncTasksOrVariants as well
There was a problem hiding this comment.
Ty! I still find it ridiculous that the linter official doesn't consider const in blocks like this unused. Removed
| Message: fmt.Sprintf("task '%s' not found", rh.taskID), | ||
| }) | ||
| } | ||
| return gimlet.NewTextResponse(t.S3Path(t.BuildVariant, t.DisplayName)) |
There was a problem hiding this comment.
We can get rid of S3Path now
validator/project_validator.go
Outdated
| var longErrorValidators = []longValidator{ | ||
| validateTaskSyncCommands, | ||
| } | ||
| var longErrorValidators = []longValidator{} |
There was a problem hiding this comment.
We can just get rid of this and the --long flag, since there's nothing in here! (Can do in another PR but might be good to do as a quick-win in the nearterm just to keep things clean)
There was a problem hiding this comment.
Sure, I wasn't sure if we regularly cycle validators in here. I'll remove it in this PR!
There was a problem hiding this comment.
I've removed the long flag from validate command as well. The latest commit has the changes for the long flag/validator
ZackarySantana
changed the title
DEVPROD-13969
Description
This removes the s3.push and s3.pull commands.
Testing
Existing unit tests.
Spruce PR
#574 has to be merged first.