DEVPROD-13862 remove commit queue collection #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
force-pushed
the
DEVPROD-13862-collection
branch
from
3d442d1 to
15e8e92
Compare
Kimchelly
approved these changes
Jan 17, 2025
| var checks = map[string]func(*testing.T){ | ||
| // note these 2 are only the same because the same project ID is used | ||
| "TestAtomicGQLQueries/abortTask/commit-queue-dequeue.graphql": checkCommitQueueDequeued, | ||
| "TestAtomicGQLQueries/unschedulePatchTasks/commit-queue-dequeue.graphql": checkCommitQueueDequeued, |
There was a problem hiding this comment.
Only somewhat related, but is this file used anymore? I can't tell if it matters but the data.json has some stuff in it that looks like legacy commit queue fields.
I'm also fine if we plan to defer test data updates to a later PR.
There was a problem hiding this comment.
Whoa good find; I'll make a note to update test data in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-13862
Description
Remove collection!!
I have one more PR coming for general cleanup, but decided to split them to reduce PR size.
Testing
Verified tests pass.
Documentation
Will clean up any documentation in the next PR