Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-11882: delete Parameter Store temporary logic for project vars #8645

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Kimchelly
Copy link
Contributor

@Kimchelly Kimchelly commented Jan 16, 2025

DEVPROD-11882

Description

This looks long, but it's mostly copy pasting the same test data for GQL tests.

Now that all projects are migrated to use Parameter Store for project vars, we can ignore the temporary project feature flags that were used during the migration. Deleting all the temporary logic means all projects will use Parameter Store without me having to opt them into it.

  • Delete all temporary logic for Parameter Store project vars. (temporary feature flags and continue on error behavior)
  • Update GQL test data and smoke test set-project-var helper that were still setting project vars directly in the DB to instead use testing implementation of Parameter Store.
  • Change the Parameter Store migration job to noop since it's no longer used. Once this is merged and deployed, I'll post a follow-up PR to delete it.

Testing

Existing tests all pass.

@Kimchelly Kimchelly requested a review from a team January 16, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant