DEVPROD-13971 Add temporary role arn to s3 commands #8682
Merged
+118
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackarySantana
changed the title
ZackarySantana
changed the title
|
Also small note, the artifacts uploaded via this cannot be retrieved by Evergreen (i.e. on the files tab it will give AccessDenied when trying to view the file (unless it has public read access). This is why it is still a temporary and not permanent addition |
Kimchelly
reviewed
Feb 7, 2025
| } | ||
| // There must be only one of local_file or extract_to specified. | ||
| catcher.NewWhen(c.LocalFile != "" && c.ExtractTo != "", "cannot specify both local file path and directory to extract to") | ||
| catcher.NewWhen(c.LocalFile == "" && c.ExtractTo == "", "must specify either local file path or directory to extract to") |
There was a problem hiding this comment.
Ty for converting these to the more modern style of error accumulation! 🙏
Kimchelly
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-13971
Description
This PR adds a temporary role arn to the s3 get and s3 put commands. This role arn will be upgraded to a permanent addition but some more work is needed to make the feature fully fledged.
I also threaded some internal buckets just for otel for now. Later on in the project, it will be used in the commands.
Testing
Unit tests. I also ran this staging task that uploads to a brand new bucket that only trusts the specific role I included in the task (relevant log line).
The bucket before:
The bucket after:
