DEVPROD-11145: Pin @leafygreen-ui/hooks to v8.1.3 for ComboBox #428
Conversation
package.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "@testing-library/dom": "10.1.0", | |||
| "@types/react": "18.2.0", | |||
| "@types/react-dom": "18.2.0", | |||
| "jackspeak": "2.1.1" | |||
| "jackspeak": "2.1.1", | |||
| "@leafygreen-ui/hooks": "8.1.3" | |||
There was a problem hiding this comment.
Did you try only forcing this version for combobox? I believe this would be the syntax:
"@leafygreen-ui/combobox/@leafygreen-ui/hooks"It would be preferable to not apply this to all LG components I think if it works
There was a problem hiding this comment.
Oh yes, I could only get this working by moving the content to Spruce package.json, but I assume that's fine
package.json
Outdated
| @@ -20,7 +20,8 @@ | |||
| "@testing-library/dom": "10.1.0", | |||
| "@types/react": "18.2.0", | |||
| "@types/react-dom": "18.2.0", | |||
| "jackspeak": "2.1.1" | |||
| "jackspeak": "2.1.1", | |||
| "@leafygreen-ui/hooks": "8.1.3" | |||
There was a problem hiding this comment.
I would prefer if we get LG to fix this on their end instead of pinning the dependency since we would likely forget about this or run into unpredictable behavior if LG updates this in the future.
There was a problem hiding this comment.
I think we can just ticket this and track it on our side. It's been broken since August 27th, I think we should patch it
…ons" This reverts commit 44fdc0a.
minnakt
changed the title
|
Commenting here just in case you missed the thread while you are out. The fix for this should be released as of today or tomorrow. So we should be able to just update Combobox. |
DEVPROD-11145
Description
The ComboBox is broken due to weird interactions with
@leafygreen-ui/hooks.You can use this CodeSandbox to verify that it doesn't work for any version after
8.1.3.