-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix/meal create] 식사 도메인 내 API 수정 #46
Merged
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
658a43a
chore: #44 API 수행시간 확인을 위한 AOP 도입
dldmsql 2b933ed
fix: #44 식사 등록 API DTO 수정 및 성능 고도화
dldmsql 2d0960c
refactor : meal 주간 식단 조회 쿼리튜닝
Qbeom0925 bb63818
fix: #44 식사 조회 API (주간/하루) 쿼리 튜닝
dldmsql 8ed92bd
fix: #44 sonarcloud 버그 수정
dldmsql 002a9ca
style: Spotless 수정
dldmsql ac7f3a3
Merge remote-tracking branch 'origin/fix/meal-create' into fix/meal-c…
dldmsql File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
src/main/java/everymeal/server/global/aop/log/LogAspect.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
package everymeal.server.global.aop.log; | ||
|
||
|
||
import everymeal.server.global.exception.ApplicationException; | ||
import org.aspectj.lang.ProceedingJoinPoint; | ||
import org.aspectj.lang.annotation.Around; | ||
import org.aspectj.lang.annotation.Aspect; | ||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Aspect | ||
@Component | ||
public class LogAspect { | ||
|
||
private LogTrace logTrace; | ||
|
||
@Autowired | ||
public LogAspect(LogTrace logTrace) { | ||
this.logTrace = logTrace; | ||
} | ||
|
||
@Around( | ||
"everymeal.server.global.aop.log.Pointcuts.allQuery() || everymeal.server.global.aop.log.Pointcuts.allService()") | ||
public Object executingTimeLog(ProceedingJoinPoint joinPoint) throws Throwable { | ||
TraceInfo traceInfo = null; | ||
try { | ||
traceInfo = logTrace.start(joinPoint.getSignature().toShortString()); | ||
Object result = joinPoint.proceed(); | ||
logTrace.end(traceInfo); | ||
return result; | ||
} catch (ApplicationException e) { | ||
if (traceInfo != null) { | ||
logTrace.apiException(e, traceInfo); | ||
} | ||
throw e; | ||
} catch (Exception e) { | ||
if (traceInfo != null) { | ||
logTrace.exception(e, traceInfo); | ||
} | ||
throw e; | ||
} | ||
} | ||
} |
89 changes: 89 additions & 0 deletions
89
src/main/java/everymeal/server/global/aop/log/LogTrace.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
package everymeal.server.global.aop.log; | ||
|
||
|
||
import everymeal.server.global.exception.ApplicationException; | ||
import java.util.UUID; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
import org.springframework.stereotype.Component; | ||
|
||
@Component | ||
public class LogTrace { | ||
|
||
private ThreadLocal<String> threadId = ThreadLocal.withInitial(this::createThreadId); | ||
|
||
public TraceInfo start(String method) { | ||
syncTrace(); | ||
String id = threadId.get(); | ||
long startTime = System.currentTimeMillis(); | ||
logger().info("[" + id + "] " + method + " ==== start"); | ||
return new TraceInfo(id, method, startTime); | ||
} | ||
|
||
public void end(TraceInfo traceInfo) { | ||
long endTime = System.currentTimeMillis(); | ||
long resultTime = endTime - traceInfo.startTime(); | ||
if (resultTime >= 1000) | ||
logger().warn( | ||
"[" | ||
+ traceInfo.theadId() | ||
+ "] " | ||
+ traceInfo.method() | ||
+ " ==== execute time = " | ||
+ resultTime | ||
+ "ms"); | ||
else | ||
logger().info( | ||
"[" | ||
+ traceInfo.theadId() | ||
+ "] " | ||
+ traceInfo.method() | ||
+ " ==== execute time = " | ||
+ resultTime | ||
+ "ms"); | ||
removeThreadLocal(); | ||
} | ||
|
||
public void apiException(ApplicationException e, TraceInfo traceInfo) { | ||
logger().error( | ||
"[" | ||
+ traceInfo.theadId() | ||
+ "] " | ||
+ traceInfo.method() | ||
+ " ==== API EXCEPTION! [" | ||
+ e.getErrorCode() | ||
+ "] " | ||
+ e.getMessage()); | ||
removeThreadLocal(); | ||
} | ||
|
||
public void exception(Exception e, TraceInfo traceInfo) { | ||
logger().error( | ||
"[" | ||
+ traceInfo.theadId() | ||
+ "] " | ||
+ traceInfo.method() | ||
+ " ==== INTERNAL ERROR! " | ||
+ e.getMessage()); | ||
removeThreadLocal(); | ||
} | ||
|
||
private void syncTrace() { | ||
String id = threadId.get(); | ||
if (id == null) { | ||
threadId.set(createThreadId()); | ||
} | ||
} | ||
|
||
private String createThreadId() { | ||
return UUID.randomUUID().toString().substring(0, 8); | ||
} | ||
|
||
private void removeThreadLocal() { | ||
threadId.remove(); | ||
} | ||
|
||
private Logger logger() { | ||
return LoggerFactory.getLogger(LogTrace.class); | ||
} | ||
} |
17 changes: 17 additions & 0 deletions
17
src/main/java/everymeal/server/global/aop/log/Pointcuts.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package everymeal.server.global.aop.log; | ||
|
||
|
||
import org.aspectj.lang.annotation.Pointcut; | ||
|
||
public class Pointcuts { | ||
|
||
@Pointcut("execution(* everymeal.server.meal.*.*(..))") | ||
public void all() {} | ||
|
||
@Pointcut("execution(* everymeal.server..*Service.*(..))") | ||
public void allService() {} | ||
|
||
@Pointcut( | ||
"execution(* everymeal.server..*Repository.*(..)) || execution(* everymeal.server..*RepositoryImpl.*(..))") | ||
public void allQuery() {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
package everymeal.server.global.aop.log; | ||
|
||
public record TraceInfo(String theadId, String method, Long startTime) {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/main/java/everymeal/server/meal/controller/dto/response/DayMealListGetResTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package everymeal.server.meal.controller.dto.response; | ||
|
||
import com.fasterxml.jackson.annotation.JsonFormat; | ||
import everymeal.server.meal.entity.MealCategory; | ||
import everymeal.server.meal.entity.MealStatus; | ||
import everymeal.server.meal.entity.MealType; | ||
import java.time.Instant; | ||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
import lombok.Setter; | ||
|
||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
@Getter | ||
@Setter | ||
@Builder | ||
public class DayMealListGetResTest { | ||
|
||
private String menu; | ||
private MealType mealType; | ||
private MealStatus mealStatus; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 일단 급한대루 Enum을 그대로 조회하였습니다. 이 부분도 튜닝하면 가능하나, 필요성은 느끼지 못하여 repository 단계에서는 하지 않았습니다. |
||
|
||
@JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy-MM-dd", timezone = "Asia/Seoul") | ||
private Instant offeredAt; | ||
|
||
private Double price; | ||
private MealCategory category; | ||
private String restaurantName; | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일단 DTO 구분으로 Test로 만들어 두었습니다.
은비님이 이어서 세부 조건문 추가하여 사용해보세요!!