[chore/s3-photo-get] 이미지 파일 s3 적재 시스템 및 구성 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dldmsql 은비님 피알 완료되고 머지한 후에 완료하겠습니다. |
Qbeom0925
changed the title
|
@dldmsql S3 Image 파일 적재 시스템 구성하였는데 리뷰 부탁드립니다! 리뷰랑 혹시 해당 테스트 케이스가 한번 확인 부탁드립니다!! |
- Meal OfferedAt 타입 변경 - 등록되지 않은 식단 포멧 적용
|
Kudos, SonarCloud Quality Gate passed! |
|
@Qbeom0925 규범님 !! 테코 오류 수정하면서 비즈니스 로직도 변경했습니다. |
dldmsql
approved these changes
Oct 24, 2023
Comment on lines
+29
to
+30
| String x = "127.091621159803"; | ||
| String y = "37.6273815936787"; |
There was a problem hiding this comment.
아뇨! 저 좌표는 마지막 서울여대 기준입니다!
검색하려는 학교 좌표기준으로 하면 데이터를 구할 수 있습니다!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
PS. Server에는 ImageKey로만 통신합합니다.
관련 이슈
#47
작업 확인 방법
s3의 presigned-url api를 통해 확인 할 수 있습니다.
추가 정보 (선택 사항)