Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : 리뷰 조회 response key 변경 #91

Merged
merged 3 commits into from
Feb 8, 2024
Merged

refactor : 리뷰 조회 response key 변경 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd932c1
refactor : 리뷰 조회 response key 변경
Feb 7, 2024
2f9236f
Merge branch 'develop' into feature/store-post-review
Feb 8, 2024
96cb86b
fix : 식당 리뷰 조회 캠퍼스 키 값 반영 해결
Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/everymeal/server/store/controller/dto/response/StoreGetReviewRes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import java.util.Map;

public record StoreGetReviewRes(
Integer reviewIdx,
Long reviewIdx,
String content,
Integer grade,
LocalDateTime createdAt,
Expand All @@ -27,7 +27,7 @@ public static List<StoreGetReviewRes> of(List<Map<String, Object>> storeReview)
images.replaceAll(S3Util::getImgUrl);
}
return new StoreGetReviewRes(
(Integer) review.get("reviewIdx"),
(Long) review.get("idx"),
(String) review.get("content"),
(Integer) review.get("grade"),
(LocalDateTime) review.get("createdAt"),
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/mybatis/mappers/StoreMapper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
left join users u on r.user_idx = u.idx and u.is_deleted = false
left join images i on r.idx = i.review_idx and i.is_deleted = false
left join store s on r.store_idx = s.idx and s.is_deleted = false
left join university un on s.university_idx = #{campusIdx} and un.is_deleted = false
join university un on s.university_idx = #{campusIdx} and un.is_deleted = false
where CASE
WHEN #{group} = 'recommend' THEN s.recommended_count > 0
WHEN #{group} = 'restaurant' THEN s.category_detail IN ('한식', '중식', '일식', '양식')
Expand Down
Loading