Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/meal service] universityIdx 통일화 작업 #98

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Conversation

dldmsql
Copy link
Member

@dldmsql dldmsql commented Feb 18, 2024

작업 내용

universityIdx 통일화 작업을 진행합니다.

변경 api spec

  • /api/v1/mealsl/restaurant POST
  • /api/v1/meals/restaurant GET
  • /api/v1/meals/day/v2 GET
  • /api/v1/meals/week/v2 GET

관련 이슈

#97

작업 확인 방법

swagger-ui 로 확인 가능합니다.

추가 정보 (선택 사항)

@dldmsql dldmsql added Refactor 코드 리팩토링 Fix 에러 수정 labels Feb 18, 2024
@dldmsql dldmsql self-assigned this Feb 18, 2024
@dldmsql
Copy link
Member Author

dldmsql commented Feb 18, 2024

@Qbeom0925 학식 조회 시, 식당 리뷰 평점 소수점 첫째 자리에서 반올림, 올림, 버림 중 무엇으로 계산해야 하나요? 일단 이번 PR에서는 반올림으로 해두었습니다.

image

Copy link
Member

@Qbeom0925 Qbeom0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

universityIdx -> campusIdx 로 통일하기로 했었던 것 같은데 혹시 확인 가능할까요???

@dldmsql
Copy link
Member Author

dldmsql commented Feb 18, 2024

universityIdx -> campusIdx 로 통일하기로 했었던 것 같은데 혹시 확인 가능할까요???

ㅎㅎ.. 변경했습니다!

Copy link

sonarcloud bot commented Feb 18, 2024

Copy link
Member

@Qbeom0925 Qbeom0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반올림 좋은 것 같습니다!! 내리는 것보다야 ㅎㅎ

고생하셨습니다!!

@dldmsql dldmsql merged commit 41d540a into develop Feb 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix 에러 수정 Refactor 코드 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants