[WIP] Refactor for scraped #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This maps between a Spanish date and an ISO representation of that date.
Following links with session information doesn't work correctly with Ruby's open-uri, so rather than using Capybara this simply strips away the session information.
This is the scraper class for the individual pages. It's a rough port of the old procedural version, but tidied up to take advantage of Scraped's class approach.
This is responsible for getting the lists of members and handling pagination.
This switches over to the new Scraped-based classes.
…factor This branch contains a fix for the AbsoluteUrl decorator where an exception is raised when an invalid `mailto:` link is encountered. We've bumped into that issue, so point to that branch to avoid it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the scraper to use
Scrapedsubclasses. This should make maintaining the scraper much easier.Part of everypolitician/everypolitician-data#16427