Discord notification fixes #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
recursivetree
commented
Jul 1, 2023
recursivetree
commented
- A few fixes that haven't found their way into Native discord notifications 5.0.x #81
fork standalone slack driver to implement standard discord API.
Co-authored-by: Loïc Leuilliot <[email protected]>
warlof
reviewed
Jul 1, 2023
| @@ -63,7 +63,7 @@ public function populateMessage(DiscordMessage $message, $notifiable) | |||
| $message | |||
| ->content('A new member has been enroll in a war! :boom:') | |||
| ->embed(function (DiscordEmbed $embed) { | |||
| $embed->timestamp($this->notification->timestamp); | |||
| $embed->timestamp(carbon($this->notification->timestamp)); | |||
There was a problem hiding this comment.
what about casting the field with carbon in the model instead ?
There was a problem hiding this comment.
Can you do that? If so, it's probably a good idea
This reverts commit d432899.
|
depends on eveseat/eveapi#376, needs to be merged together |
recursivetree
force-pushed
the
clean-discord-fixes
branch
from
0a1f05b to
47319c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.