Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: huge refactor #1384

Merged
merged 90 commits into from
Feb 18, 2025
Merged

UI: huge refactor #1384

merged 90 commits into from
Feb 18, 2025

Conversation

DimaAmega
Copy link
Collaborator

@DimaAmega DimaAmega commented Dec 5, 2024

This pr improves react router by providing type safe wrappers

React router v7 is type safe, but i don't like the idea of running separate react-router typegen command to generate types, my opinion/approach is: we already have all these types in src code

Improvements/Changes:

  • Strong type safety around routing stuff (links, search params, redirects, loaders, actions, url params)
  • Better declarative actions api: one route action contains a few named actions export actions = Record<ActionName, ActionHandler<ActionBody>> so one fetcher works with one specific action on page and they are linked by the correct types
  • Add default error boundary to the route automatically if not provided

Minor improvements:

  • Better control of bundled chunks

@DimaAmega DimaAmega changed the title ui/refactor huge UI: huge refactor Dec 5, 2024
@DimaAmega DimaAmega merged commit c6056c7 into main Feb 18, 2025
25 checks passed
@DimaAmega DimaAmega deleted the ui/refactor-huge branch February 18, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant