Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added revival fluid ( message link in comments ) and better naming for variables #31

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

Sanctious
Copy link
Contributor

@Sanctious Sanctious changed the base branch from master to dev June 18, 2023 17:13
@evilfactory
Copy link
Owner

The code for reviving the corpse doesn't give the character back their control and gives them husk servant role

@Sanctious
Copy link
Contributor Author

oh so this part of code doesnt get called ?
image

@evilfactory
Copy link
Owner

I suggest testing, this should trigger if the character is being controlled, but I don't know if revive restores control.

@Sanctious
Copy link
Contributor Author

oh thanks i will test it.

@Sanctious
Copy link
Contributor Author

yeh you are right it didnt work fixing it

@Sanctious
Copy link
Contributor Author

i think its fixed now

@evilfactory
Copy link
Owner

The code should do something in case it doesn't find the character. What if the spectator decided to become a monster or if the person controlling the corpse left the game? The code will error, but it probably shouldn't just ignore in case it doesn't find the client, maybe it could set it as a ghostrole?

@Sanctious
Copy link
Contributor Author

hi !
Oh yes mb.
i will fix it !

@Sanctious Sanctious force-pushed the huskitems-extension branch from 9722150 to 737d571 Compare June 19, 2023 17:04
@Sanctious Sanctious marked this pull request as draft June 19, 2023 20:03
@Dutch-VanDerLinde
Copy link

Dutch-VanDerLinde commented Jun 24, 2023

doesn't seem like there are any issues with this

@Sanctious
Copy link
Contributor Author

yeh but i marked it as draft since its kinda dirty and it doesnt really fit into the game. im going to add a variant of this later ( its more balanced and hopefully cleaner )

@Dutch-VanDerLinde
Copy link

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants