You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though Tailwind V4 is in beta, I believe the syntax for theme override is unlikely to change, so this PR should be future proof. But if they do change I'm happy to follow-up.
Also, I noticed there is no pipeline for CHANGELOG generation and automatic publication. Happy to open a follow-up PR to set up changesets if you think that's helpful.
I have not bumped version or added to CHANGELOG.md either. Please let me know if you want me to do that in this PR as well.
@vnphanquang Thank you for the contribution! I have one question. Prior to v4, there were special colors inherit, current, transparent, black, white. We add them here to make Harmony a drop-in replacement. Is it still a thing in v4?
@11bit that's a very nice catch! As of beta.2, inherit, current, transparent will be available by default, but we do need to add black and white back in the theme override, which I did in a new commit 3e20f1a. Thanks for checking!
Also, I noticed there is no pipeline for CHANGELOG generation and automatic publication. Happy to open a follow-up PR to set up changesets if you think that's helpful.
Also, I noticed there is no pipeline for CHANGELOG generation and automatic publication. Happy to open a follow-up PR to set up changesets if you think that's helpful.
It would be very nice ❤️
Thanks @11bit for the quick merge. A follow-up is at #14. Please feel free to give feedback. Cheers!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a build target to
tailwind/index.css, intended to support Tailwind V4 (currently in beta), which allows theme override using CSS syntax.More information here: https://tailwindcss.com/docs/v4-beta#overriding-the-default-theme.
Note
Even though Tailwind V4 is in beta, I believe the syntax for theme override is unlikely to change, so this PR should be future proof. But if they do change I'm happy to follow-up.
Also, I noticed there is no pipeline for CHANGELOG generation and automatic publication. Happy to open a follow-up PR to set up changesets if you think that's helpful.
I have not bumped version or added to CHANGELOG.md either. Please let me know if you want me to do that in this PR as well.
Thanks!