Add Undo/Redo #149
Merged
Add Undo/Redo #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
stores/history.ts
Outdated
| import { debounce } from '../lib/time.js' | ||
| import { current, type LchValue } from './current.js' | ||
|
|
||
| let $undos = atom<LchValue[]>([]) |
There was a problem hiding this comment.
Do we have $ in store name in other stores?
If not it is better to keep origin name system.
We can switch to $ in separated PR. I like this idea.
There was a problem hiding this comment.
done. I understand it and it was that before. but with prev, I few times was confused is it a variable or a store. and in documentation I saw this $ sign. then I left with undos store and $prev store
There was a problem hiding this comment.
If you have time, let's migrate to $ when we will finish with this PR
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 20, 2024
ai
reviewed
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #148
$prev is needed for storing previous color. I tried to use oldValue from subscribe, but because of debounce, it can be the same as value.$prev initialised with 0 color to avoid checking for null. I set correct first value in subscribe, when oldValue is not passedon cmd + Y in macOS Safari usually opens history, is it okay that now I prevent to open it?