Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test @texet/color in chart render #152

Closed
wants to merge 1 commit into from

Conversation

AlexDroomer
Copy link
Contributor

@AlexDroomer AlexDroomer commented Aug 6, 2024

Test env

--benchmark-color: #a36825
searchParams: ?bench#70,0.1,296,100

Initial benchmark

initial benchmark

Freeze max 20
Freeze sum 23
Worker max 50
Worker sum 177
Paint      52

benchmark with culori inGamut(colorSpace)

benchmark with culori inGamut(colorSpace)

Freeze max 5
Freeze sum 7
Worker max 46
Worker sum 149
Paint      46

export const inRGB = inGamut('rbg');
export const inP3 = inGamut('p3');
export const inRec2020 = inGamut('rec2020');

texet/color benchmark

texet/color benchmark

Freeze max 4
Freeze sum 5
Worker max 56
Worker sum 195
Paint      58

Chart rendering works. During the measurement process, I discovered that when converting oklch to another color space in texet, the resulting values ​​differ from culori ±2e-9 to ±2e-10

@ai
Copy link
Member

ai commented Aug 6, 2024

benchmark with culori inGamut(colorSpace)

Hm, is it the better way to optimize it?

Can you open another PR with that? Maybe it is better than using texet/color

@AlexDroomer
Copy link
Contributor Author

Can you open another PR with that? Maybe it is better than using texet/color

Check it #153

@ai ai closed this Aug 6, 2024
@AlexDroomer AlexDroomer deleted the test-texet-color branch August 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants