Open / close main panel with swipes #156
Conversation
baileys-li
force-pushed
the
rework/main-panel
branch
from
bc4aba1 to
42a9fbe
Compare
view/main/index.pug
Outdated
| main.main | ||
| button.main_expand( aria-label="Expand or collapse panel" type="button" ) | ||
| main.main.layout_main#main-panel | ||
| button.main_expand( aria-label="Main panel" type="button" aria-expanded='true' aria-controls="main-panel" ) |
There was a problem hiding this comment.
Why we change label? The new label doesn't describe the action
There was a problem hiding this comment.
aria-expanded already say if element is collapsed or expanded. Screen reader even notify user on attribute change.
So with old label it sounds like oiled oil (yeah, I didn't found English idiom)
PS It's supposed to notify only that the status has changed, but on my mac, Voice Over is re-reading the entire message:
Main panel, expanded, button
Main panel, collapsed, button
There was a problem hiding this comment.
I will ask in a11y chat how people deal with such cases
There was a problem hiding this comment.
Main panel, expanded, button
Main panel, collapsed, button
Good note about expanded/collapsed. But I still prefer verb there.
Maybe Toggle panel?
There was a problem hiding this comment.
Also, let’s remove main since this word doesn’t say anything
There was a problem hiding this comment.
Change to toggle.
PS Miss @glafirazhur confirmed that it's ok when a button in such contexts doesn't have a action label. For example, accordion pattern
|
I will be able to review it a little later. I need to see how it actually work. |
|
Sure |
|
Looks great on real device. I am ready for merge when we will fix the label. |
|
Thanks. Amazing work. |
|
Thanks |
Fix #26
Minor changes for main panel logic