Result Documentation #365
Result Documentation #365
Conversation
dalefrancis88
force-pushed
the
docs/Result
branch
from
0470586 to
b0441b8
Compare
|
Hey @evilsoft or @HenriqueLimas I'd love an initial set of 👀 on this. I think everything is ready for review except the |
|
@evilsoft Thanks for looking at this. I'll get the review items fixed up and the |
There was a problem hiding this comment.
@dalefrancis88 Looks like you got all the stuff I found in that last review.
BUT I found a few more things, but feel 💯 that we can 🚢 🇮🇹 after these things are addressed.
Thanks so much for tackling this. These Sum Types can be very brutal to document.
docs/src/pages/docs/crocks/Result.md
Outdated
| ensure(isNumber) | ||
|
|
||
| // swapWithDefault :: Result e a -> Result String Number | ||
| const swapWithDefault = |
There was a problem hiding this comment.
Still think we need an example that transforms as it swaps instead of using two constants. Thoughts?
There was a problem hiding this comment.
I've written a different version, hopefully it's a bit better, lmk
|
Think this will do it. Amazing work on this @dalefrancis88!
|
|
No problem, thanks for your limitless patience :) |
This is to add the documentation for
Resultper #42Not ready for review, but happy for input