-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(distr): add distribution authorization #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Great work @Vvaradinov! Left one nit. Also would be great to add some unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, needs tests and the checkAddressInList
function can be removed and replaced with slices.Contains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @Vvaradinov, some minor comments from my side ✌️
https://github.com/Mergifyio backport ledger/v0.47.x |
❌ No backport have been created
Git reported the following error:
|
https://github.com/Mergifyio backport ledger/v0.47.x |
✅ Backports have been created
|
(cherry picked from commit 3c10148) # Conflicts: # tests/integration/distribution/keeper/grpc_query_test.go # x/distribution/types/codec.go
Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: tom <[email protected]>
Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: tom <[email protected]>
Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: tom <[email protected]>
Description
This PR adds an
x/distribution
specific Authorization to use with EVM extensions. It includes the msg url and the allowed list so smart contract developers are able to set multiple accounts for the transactions.Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change