-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cachemulti): add Copy method #52
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
5af2238
to
b4580c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @0xstepit !
Co-authored-by: Tom <[email protected]>
for key, val := range store.cache { | ||
newVal := *val // Create a copy of the cValue | ||
cacheCopy[key] = &newVal | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for key := range store.unsortedCache { | ||
unsortedCacheCopy[key] = struct{}{} | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for key, store := range cms.stores { | ||
store, ok := store.(*cachekv.Store) | ||
if ok { | ||
newStores[key] = store.Copy() | ||
} | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
for key, value := range cms.keys { | ||
newKeys[key] = value | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Co-authored-by: tom <[email protected]> Co-authored-by: Tom <[email protected]>
Co-authored-by: tom <[email protected]> Co-authored-by: Tom <[email protected]>
Co-authored-by: tom <[email protected]> Co-authored-by: Tom <[email protected]>
Add a deep copy method to the store.