Added feature values #38
Conversation
featureflags/http/db.py
Outdated
| name: str, | ||
| *, | ||
| conn: SAConnection, | ||
| ) -> UUID: |
There was a problem hiding this comment.
What if there is no Value in db ? Maybe it should be Optional ?
featureflags/http/db.py
Outdated
| value_default: str, | ||
| *, | ||
| conn: SAConnection, | ||
| ) -> UUID: |
There was a problem hiding this comment.
As far as I know, if on_conflict_do_nothing does nothing, query won't return an id
ui/src/Dashboard/Value.jsx
Outdated
| ); | ||
| } | ||
|
|
||
| function copyToClipboard(text, msg) { |
There was a problem hiding this comment.
Ideally this must go to some utils.js or utils/clipboard.js.
Same for function _replace(array, value, newValue) bellow since this code is a duplicate from Flag.jsx
ui/src/Dashboard/actions.js
Outdated
| } | ||
| break; | ||
| case Type.NUMBER: | ||
| if (!isNumber(check.value_number || !check.hasOwnProperty('value_number'))) { |
There was a problem hiding this comment.
This row has a bug (introduced by me :)).
It should be isNumber(check.value_number) || not isNumber(check.value_number ||
There was a problem hiding this comment.
And the same bug exists in getFlagSaveOperations
|
Overall lgtm |
ui/src/Base.jsx
Outdated
| @@ -1,4 +1,4 @@ | |||
| import { Navigate, useLocation } from 'react-router-dom'; | |||
| import {Navigate, useLocation, useNavigate} from 'react-router-dom'; | |||
There was a problem hiding this comment.
looks like linter missed this part
ui/src/Dashboard/Dashboard.jsx
Outdated
| ) | ||
| ) | ||
| } | ||
| {/*{!!selected ? <FlagsContainer project={projectMap[selected]}/> :*/} |
There was a problem hiding this comment.
maybe should be uncomented?
No description provided.