track each subquery field proc separately #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aims to improve subquery fields tracking.
Problem
Let's consider case when several fields are resolved using same subgraph. In this case both fields will have the same duration (from superSlowField), but this is wrong.
In production it looks like this:
Solution
We need to track each field resolver individually. In this pr
wrap_proc
will wrap field'sproc
function (proc function is basically a function with@define
decorator on it) so instead of trackingresult = result_proc()
which is a_create_result_proc
we will track eachproc
individually, see:hiku/hiku/sources/graph.py
Lines 50 to 58 in 8b5598c
Result
Simple example which prints
observe
argsBefore:
After: