[bugfix] Do not create the file before calling Part#write

evolvedbinary · Nov 29, 2024 · 647669e · 647669e
1 parent 1804e87
commit 647669e
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/exist-core/src/main/java/org/exist/http/servlets/HttpRequestWrapper.java b/exist-core/src/main/java/org/exist/http/servlets/HttpRequestWrapper.java
@@ -61,7 +61,16 @@
 public class HttpRequestWrapper implements RequestWrapper {
 
     private static final Logger LOG = LogManager.getLogger(HttpRequestWrapper.class);
-
+
+    private static final Path TMP_DIR;
+    static {
+        try {
+            TMP_DIR = Files.createTempDirectory("");
+        } catch (final IOException e) {
+            throw new RuntimeException("Unable to create temporary directory for HttpRequestWrapper", e);
+        }
+    }
+
     private final HttpServletRequest servletRequest;
     @Nullable private final String formEncoding;
     @Nullable private String containerEncoding;
@@ -545,13 +554,19 @@ public List<Path> getFileUploadParam(final String name) {
 
             if (temporaryUploadedFilePath == null) {
                 try {
-                    temporaryUploadedFilePath = Files.createTempFile(null, null);
+                    final String tmpFilename = UUID.randomUUID().toString() + ".tmp";
+
+                    temporaryUploadedFilePath = TMP_DIR.resolve(tmpFilename);
                     part.write(temporaryUploadedFilePath.toAbsolutePath().toString());
                 } catch (final IOException e) {
                     LOG.warn(e);
                     continue;
                 }
 
+                if (temporaryUploadedFilesPathCache == null) {
+                    temporaryUploadedFilesPathCache = new HashMap<>();
+                }
+
                 temporaryUploadedFilesPathCache.put(part, temporaryUploadedFilePath);
             }