Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master issue tree expansion woes: #513

Open
duncdrum opened this issue Sep 14, 2021 · 2 comments
Open

master issue tree expansion woes: #513

duncdrum opened this issue Sep 14, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@duncdrum
Copy link
Contributor

duncdrum commented Sep 14, 2021

There are a number of problems / bugs with the tree view of this extension. Not all of these are probably related by the same underlying technical or code issue, but i think its a good idea to start collecting them in a central place.

  1. GUI expansion click vs double-click
    A double-click should not trigger click expansion. The UI should be able to clearly distinguish between the two events. Needs tests. Also not that double-click for properties does not apply to other tree items, only the root server connection entry, i suggest only showing properties on right-click for the whole tree.
Screen.Recording.2021-09-14.at.14.10.49.mov
  1. Tree expansion consistency
    seems to work but needs tests for different api endpoints. I.e. the last expansion is recalled when collapsing and expanding ancestor items.
Screen.Recording.2021-09-14.at.14.29.07.mov
  1. Missing UI indicators for expand/collapse

see VSC, no reason to use visual clues to inform users of what is what. Probably better for accessibilty as well.

Screenshot 2021-09-14 at 14 43 22

  1. DOM is not nested
    having a flat html representation of the tree items is very counter-intuitive, it will also not play nicely with other theia vsc extensions, which all expect nested trees to be nested html.

see #411 this html fragment
Screenshot 2021-09-14 at 15 04 32

to the 4 entries Servers, localhost, db, Security
Screenshot 2021-09-14 at 15 06 10

  1. Insta collapse when creating a new connection
Screen.Recording.2021-09-14.at.14.10.49.mov
@duncdrum duncdrum added the bug Something isn't working label Sep 14, 2021
duncdrum added a commit that referenced this issue Sep 14, 2021
see  #397
the spec currently fails in headless mode but passes in headed mode

see #513
@duncdrum duncdrum mentioned this issue Sep 14, 2021
@duncdrum
Copy link
Contributor Author

see #413

@ccheraa
Copy link
Member

ccheraa commented Oct 22, 2021

The missing indicators problem is tracked down to PR #472, I still don't know how exactly that PR affected the indicators.
Interestingly, when you open a document from the tree, the indicators are back again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants