-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added volume, network and port to docker compose #814
base: master
Are you sure you want to change the base?
Conversation
@djpiper28 is attempting to deploy a commit to the evroon's projects Team on Vercel. A member of the Team first needs to authorize it. |
oh yeah I have some helm charts (Kubernetes for Bracket) should I make a PR to add them? |
@evroon are you able to review this when you have time please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-compose.yml
looks good, I just have some comments about the docs.
Also, maybe we should add a volume in the production example as well now that we're adding it to the docker-compose.yml
NEXT_PUBLIC_API_BASE_URL: "https://bracket.mywebsite.com" | ||
# Go to https://dashboard.hcaptcha.com/signup, create a site and put the site key here | ||
NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "xxxxx" | ||
NODE_ENV: "production" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want to keep the NODE_ENV: "production"
right?
NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "xxxxx" | ||
NODE_ENV: "production" | ||
NEXT_PUBLIC_API_BASE_URL: "http://your-site.com:8400" | ||
NEXT_PUBLIC_HCAPTCHA_SITE_KEY: "10000000-ffff-ffff-ffff-000000000001" # Public test key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the instruction # Go to https://dashboard.hcaptcha.com/signup, create a site and put the site key here
here, since it is more clear what the value here should be. Putting a test key here would probably result in users just copy/pasting and accidentally using the test key in production without noticing I think
Fixes issue where containers cannot to talk to each other where the default docker network is isolated.