Fix Python 3.8 multiprocessing issue(?); note: QProgressBar disappear…

…s using 'Fusion' on Windows when opening a file explorer

transcriber/collator/model.py

@@ -21,15 +21,14 @@ def __init__(self):
         self.state = False
 
     @QtCore.pyqtSlot(str, list)
-    def collate(self, save_file, filenames):
+    def collate(self, collated_file, filenames):
         self.collation_started.emit()
-        with open(save_file, "w") as collated_file:
-            self.process = Process(
-                target=utils.collate, args=(collated_file, filenames,)
-            )
-            self.process.start()
-            self.state = True
-            self.process.join()
+        self.process = Process(
+            target=utils.collate, args=(collated_file, filenames,)
+        )
+        self.process.start()
+        self.state = True
+        self.process.join()
         if self.state:
             logging.info(
                 f"Collation of {len(filenames)} file(s) was successful"

transcriber/collator/test_collator.py

@@ -40,14 +40,14 @@ def test_collator_collate(
         mock_join.assert_called_once()
 
     @mock.patch("transcriber.collator.utils.collate_files")
-    def test_collate(self, mock_collate):
-        save_file = mock.Mock()
+    @mock.patch("builtins.open", new_callable=mock.mock_open)
+    def test_collate(self, mock_file, mock_collate):
+        save_file = "this/is/the/save/file.csv"
         filenames = ["this/is/a/test.csv"]
         utils.collate(save_file, filenames)
         mock_collate.assert_called_with(
-            save_file, [transcribed_filename(f) for f in filenames]
+            mock_file(), [transcribed_filename(f) for f in filenames]
         )
-        save_file.close.assert_called_once()
 
     def test_collate_files(self):
         num_files = 3

transcriber/collator/utils.py

@@ -3,11 +3,11 @@
 from transcriber.converter.dbfworker import utils
 
 
-def collate(save_file, filenames):
-    collate_files(
-        save_file, [utils.transcribed_filename(f) for f in filenames],
-    )
-    save_file.close()  # parent won't close this, so we have to
+def collate(collated_file, filenames):
+    with open(collated_file, "w") as save_file:
+        collate_files(
+            save_file, [utils.transcribed_filename(f) for f in filenames],
+        )
 
 
 def collate_files(collated_file, filenames):