Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logo property #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a logo property #68

wants to merge 1 commit into from

Conversation

linkmauve
Copy link
Contributor

Fixes #40.

kjetilk
kjetilk previously approved these changes Jul 30, 2019
View reviewed changes
Copy link
Collaborator

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Now, we need a process to get it into the namespace document.

@linkmauve
Copy link
Contributor Author

You mean take this change once it is merged and publish it at http://usefulinc.com/ns/doap#?

@kjetilk
Copy link
Collaborator

kjetilk commented Jul 30, 2019

You mean take this change once it is merged and publish it at http://usefulinc.com/ns/doap#?

Yeah, currently, we don't have any automated means for that, so it depends on @ewilderj 's time.

@linkmauve
Copy link
Contributor Author

linkmauve commented Sep 7, 2020 •
edited
Loading

Hi @ewilderj, any news on that?

bjc pushed a commit to bjc/prosody that referenced this pull request Jan 30, 2021
@Zash
doap: Link to logo
229730f 
Link Mauve added logo to the xmpp doap namespace, waiting for
ewilderj/doap#68 to be merged

Also,
Happy New Year!
bjc pushed a commit to bjc/prosody that referenced this pull request Mar 14, 2021
@Zash
doap: Link to logo
cfec5ef 
Link Mauve added logo to the xmpp doap namespace, waiting for
ewilderj/doap#68 to be merged

Also,
Happy New Year!
@ewilderj
Copy link
Owner

I like the notion of this -- can you speak to the range of Container? I think the most expected thing would be for someone to reference an image file, or a list of image files. This PR would be best if it also incorporated an amended example to show usage?

@ewilderj
Copy link
Owner

I'm wondering about pursuing this in the same category as the #50 screenshot property. I don't think the range of sioc:Container is appropriate, given my reading of http://rdfs.org/sioc/spec/#term_Container -- however no objection to the property name, so it makes sense. I think we can usefully use terms from https://github.com/facebookarchive/open-graph-protocol/blob/master/ns/ogp.me.rdf

@ewilderj ewilderj dismissed kjetilk’s stale review June 10, 2024 23:52

Unapproving so we can have the discussion about the range

@ewilderj ewilderj self-assigned this Jun 10, 2024
@kjetilk
Copy link
Collaborator

kjetilk commented Jun 11, 2024

Yes, sioc:Container may not be appropriate. There's foaf:Image, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjetilk kjetilk kjetilk left review comments

Assignees

@ewilderj ewilderj

Labels
feature-discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a logo property
3 participants
@linkmauve @kjetilk @ewilderj