enabledChanged/isEnabled and connectedChanged/isConnected + setOn/Off #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pio.ini: enable artnet and ddp Module.h - rename enabled to isEnabled - refactor event functions enabledChanged and connectedChanged SysModModules - rename Modules class to SysModModules - add isConnected - mdlEnabled: check of value.size same as nrOfModules otherwise recreate - rename connected() to connectedChanged() SysModWeb - connectedChanged: only addhandlers if isConnected (tbd: disable???) UserModArtNet and DDP - disabled by default (in constructor) - connectedChanged commented! (as main checks if connected) UserModE131 - disabled by default (in constructor) - connectedChanged and enabledChanged call setOn and setOff (tbd setoff!) UserModHA (not included in built yet) - disabled by default (in constructor) - connectedChanged; tbd if disconnected, and move to setOn and setOff (see E131)
|
Implement model which deals with connected goes on or off and enabled goes on or off. Modules catches these functions and can use it to setOn or setOff their functionality. |
netmindz
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pio.ini: enable artnet and ddp
Module.h
SysModModules
SysModWeb
UserModArtNet and DDP
UserModE131
UserModHA (not included in built yet)