Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Req request backend #1065

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Add Req request backend #1065

merged 1 commit into from
Sep 10, 2024

Conversation

liamwhite
Copy link
Contributor

When communicating with storage backends over a local socket (using sendfile, responses are not limited to small chunks), hackney does not reliably handle responses above about 64MiB - see benoitc/hackney#729

This adds a Req backend. Req is widely used and does not have such a limitation.

@bernardd
Copy link
Contributor

Looks good, thanks @liamwhite! Apologies for the delay getting this merged.

@bernardd bernardd merged commit 94ccdc8 into ex-aws:main Sep 10, 2024
@liamwhite liamwhite deleted the req branch September 10, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants