Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExPhoneNumber.Utilities#truncate_too_long_number/1 #49

Merged
merged 2 commits into from
Oct 9, 2021

Conversation

tomciopp
Copy link
Contributor

@tomciopp tomciopp commented Oct 1, 2021

Add function that can truncate too long phone numbers.

Adds the truncate_too_long_number method with corresponding tests as referenced in issue #43. Let me know if you have any questions or have any requests for changes:

Add method truncateTooLongNumber

Implement function

and corresponding test

@szymon-jez szymon-jez requested a review from josemrb October 4, 2021 12:29
@szymon-jez szymon-jez changed the title feat(ExPhoneNumber.Utilities#truncate_too_long_number/1): Add functio… Add ExPhoneNumber.Utilities#truncate_too_long_number/1 Oct 4, 2021
@josemrb josemrb merged commit 2eb684e into ex-phone-number:develop Oct 9, 2021
@josemrb
Copy link
Collaborator

josemrb commented Oct 9, 2021

Hi @tomciopp,

Thanks for your pull request.

I had already done this but I was missing the tests, so I used my implementation and refactored your tests to follow our convention.

If you want to contribute in the future, my main recommendation would be that the code should follow the original implementation as closely as possible.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants