Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Settings #1209

Merged
merged 10 commits into from
Sep 19, 2023
Merged

✨ Settings #1209

merged 10 commits into from
Sep 19, 2023

Conversation

JuampiRombola
Copy link
Contributor

@JuampiRombola JuampiRombola commented Sep 19, 2023 •
edited
Loading

closes #1092

image image

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 2:37pm

@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 13:32 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 13:32 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 13:32 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 13:32 — with GitHub Actions Inactive
sebipap
sebipap reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@sebipap sebipap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left minor comments

components/AdvancedSwitch/index.tsx Outdated Show resolved Hide resolved
components/AdvancedSwitch/index.tsx Outdated Show resolved Hide resolved
components/DropdownMenu/index.tsx Outdated Show resolved Hide resolved
components/Settings/index.tsx Outdated Show resolved Hide resolved
jgalat
jgalat previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jgalat jgalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! minor comments

components/AdvancedSwitch/index.tsx Outdated Show resolved Hide resolved
components/DropdownMenu/index.tsx Outdated Show resolved Hide resolved
components/Settings/index.tsx Outdated Show resolved Hide resolved
components/Settings/index.tsx Outdated Show resolved Hide resolved
components/Settings/index.tsx Outdated Show resolved Hide resolved
components/Settings/index.tsx Outdated Show resolved Hide resolved
franm91
franm91 previously approved these changes Sep 19, 2023
View reviewed changes
sebipap
sebipap previously approved these changes Sep 19, 2023
View reviewed changes
components/AdvancedSwitch/index.tsx Outdated Show resolved Hide resolved
@JuampiRombola JuampiRombola dismissed stale reviews from sebipap and franm91 via e6b7013 September 19, 2023 14:33
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:39 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:39 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:39 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:55 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:55 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:55 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola temporarily deployed to Test September 19, 2023 14:55 — with GitHub Actions Inactive
@JuampiRombola JuampiRombola merged commit e6b7013 into main Sep 19, 2023
@JuampiRombola JuampiRombola deleted the settings branch September 19, 2023 15:11
@JuampiRombola JuampiRombola temporarily deployed to Production September 19, 2023 15:11 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franm91 franm91 franm91 approved these changes

@jgalat jgalat jgalat approved these changes

@sebipap sebipap sebipap left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feedback from Nico P.
4 participants
@JuampiRombola @jgalat @sebipap @franm91