[🚀 ESL Popup] add position-origin attribute #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshovchko
requested review from
ala-n,
abarmina,
Natalie-Smirnova,
fshovchko,
HenadzV,
NastaLeo and
a team
dshovchko
changed the title
dshovchko
changed the title
ala-n
reviewed
Nov 6, 2024
| break; | ||
| case 'right': | ||
| x = inner.right; | ||
| x = hasInnerOrigin ? inner.x : inner.right; |
There was a problem hiding this comment.
Just a note: probably we can use left/right key and some generic function for invertion in future
| @@ -401,10 +407,11 @@ export class ESLPopup extends ESLToggleable { | |||
| const triggerRect = Rect.from(this.activator).shift(window.scrollX, window.scrollY); | |||
| const {containerRect} = this; | |||
|
|
|||
| const innerMargin = this._offsetTrigger + arrowRect.width / 2; | |||
| const innerMargin = this._offsetTrigger + (this.positionOrigin === 'inner' ? 0 : arrowRect.width / 2); | |||
There was a problem hiding this comment.
Do we need? Practically there is no limitation to have arrow for inner behaviour
There was a problem hiding this comment.
This is not a limitation. This is just a position adjustment.
yadamskaya
approved these changes
Nov 6, 2024
ala-n
approved these changes
Nov 6, 2024
I'm going to create a few issues to this |
fshovchko
approved these changes
Nov 6, 2024
NastaLeo
approved these changes
Nov 6, 2024
abarmina
approved these changes
Nov 6, 2024
Co-authored-by: Anna Barmina <[email protected]>
Natalie-Smirnova
approved these changes
Nov 6, 2024
|
🎉 This PR is included in version 5.0.0-beta.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new attribute
position-origin="outer|inner"that allows or disallows to overlap of the trigger by a popup window.Closes: #2746