#245-adding-backend-inference-for-the-path-api

[jana-selva]

Closes #245

[tkilias]

backend_aware_bucketfs_params returns SaaS or on-prem parameters, so if you specifically want to test on-prem, you need to skip SaaS. Alternatively, we could also think about, only having one test and check on the inferred path, if we can upload files to the path.

[tomuben]

I vote to keep two tests, as the checks in one test would become more complex.....

[ahsimb]

It is probably better to return the StorageBackend enum than a string.

[ckunki]

Unfortunately, enum StorageBackend is part of notebook-connector, which BFSPY does not depend on (an should not!).

We could decide to implement another enum here, though.

[ahsimb]

I meant the StorageBackend in this repo. It already exist.

[sonarqubecloud]

Quality Gate failed

Failed conditions
59.3% Coverage on New Code (required ≥ 80%)
3 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[ckunki]

This will fail if a backend other than onprem is selected.

Compare

• backend_aware_bucketfs_params
• backend_aware_saas_bucketfs_params
• backend_aware_onprem_bucketfs_params

all in pytest-plugins/pytest-backend

[ckunki]

OK - please excuse me.
I probably was wrong.
I didn't notice that you test case should only be executed onprem, but skipped on saas.

I now replaced fixture backend by use_onprem which should serve this purpose in my suggestion above.
Still, the test case needs to call pytest.skip() by himself.

[ckunki]

As @ahsimb said: This probably could go to production code.

[ckunki]

Or simply use StorageBackend, maybe making it public by importing in bucketfs/__init__.py.

[ahsimb]

Sorry, for a late comment. I think it might be useful to also include the Mounted BucketFS path here (and in the infer_backend). This backend is just a file path that can be used by either a UDF or for testing. See build_path.
The ValueError would probably be "Unsupported backend". Insufficient parameters would be thrown by the infer_backend. If it was happy with the parameters, this must be some kind of a new backend, this function is unaware of or really doesn't want to support. This is a very small thing of course.

[ahsimb]

Compare to the enum

[ckunki]

Suggested change

	def test_infer_path_onprem(backend, backend_aware_bucketfs_params):
	"""
	Creates the PathLike and validates it.
	"""
	if backend == "saas":
	pytest.skip()
	def test_infer_path_onprem(backend_aware_bucketfs_params, use_onprem):
	"""
	Creates the PathLike and validates it.
	"""
	if not use_onprem:
	pytest.skip()

[ckunki]

OK - please excuse me.
I probably was wrong.
I didn't notice that you test case should only be executed onprem, but skipped on saas.

I now replaced fixture backend by use_onprem which should serve this purpose in my suggestion above.
Still, the test case needs to call pytest.skip() by himself.

[ckunki]

Suggested change

	def test_infer_path_saas(
	backend, saas_host, saas_pat, saas_account_id, backend_aware_saas_database_id
	):
	"""
	Creates the SaasBucket with fixture details realted to Saas and validates it.
	"""
	if backend != "saas":
	pytest.skip("The test runs only with SaaS database")
	def test_infer_path_saas(
	use_saas, saas_host, saas_pat, saas_account_id, backend_aware_saas_database_id
	):
	"""
	Creates the SaasBucket with fixture details realted to Saas and validates it.
	"""
	if not use_saas:
	pytest.skip("The test runs only with SaaS database")