#19 move slc notebook #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicoretti
reviewed
Jul 15, 2024
Nicoretti
previously approved these changes
Jul 15, 2024
Nicoretti
previously approved these changes
Jul 15, 2024
Nicoretti
previously approved these changes
Jul 16, 2024
2. Added class SlctManager 3. Added integration test 4. Added a helper function for creating an pyexasol connection which also runs the ALTER SESSION command for all registered languages
tomuben
force-pushed
the
feature/19_move_slc_notebook
branch
2 times, most recently
from
665ce3c
to
e0957f9
Compare
tomuben
force-pushed
the
feature/19_move_slc_notebook
branch
from
e0957f9
to
2be5218
Compare
Nicoretti
approved these changes
Jul 19, 2024
Comment on lines
+55
to
+63
| @contextlib.contextmanager | ||
| def enter(self): | ||
| """Changes working directory and returns to previous on exit.""" | ||
| prev_cwd = Path.cwd() | ||
| os.chdir(self.root_dir) | ||
| try: | ||
| yield | ||
| finally: | ||
| os.chdir(prev_cwd) |
There was a problem hiding this comment.
with python 3.11 there is a ready to go context manager for changing the dir is available see (https://docs.python.org/3/library/contextlib.html#contextlib.chdir)
| ctx.emit("success") | ||
| / | ||
| """) | ||
| con = open_pyexasol_connection_with_lang_definitions(slc_secrets, schema='TEST') |
There was a problem hiding this comment.
having a connection fixture would be a possible simiplification
There was a problem hiding this comment.
Would not work in this case, as I have these dependencies to the other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/ai-lab#19
open_pyexasol_connection_with_lang_definitionsinlanguage_container_activation.pywhich creates a pyexasol connection and appliesALTER SESSIONcommand with all registered languagesslct_managerwhich provides a wrapper for exaslct commands used in thescript_languages_containernotebooksexasol-script-languages-container-toolas dependency