Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add security linter bandit to nox #208

Merged
merged 30 commits into from
Sep 25, 2024
Merged

add security linter bandit to nox #208

merged 30 commits into from
Sep 25, 2024

Conversation

Jannis-Mittenzwei
Copy link
Contributor

closes #74

@Jannis-Mittenzwei Jannis-Mittenzwei added the feature Product feature label Jun 20, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei self-assigned this Jun 20, 2024
ckunki
ckunki requested changes Jul 11, 2024
View reviewed changes
exasol/toolbox/metrics.py Outdated Show resolved Hide resolved
test/unit/report_test.py Outdated Show resolved Hide resolved
ckunki
ckunki previously requested changes Aug 2, 2024
View reviewed changes
test/unit/report_test.py Outdated Show resolved Hide resolved
Nicoretti
Nicoretti reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could add some basic information regarding the security linter to the doc e.g. where to configure the output ...

.security.json Outdated Show resolved Hide resolved
Nicoretti
Nicoretti previously approved these changes Sep 2, 2024
View reviewed changes
@ckunki
Copy link
Contributor

ckunki commented Sep 23, 2024

Today I had the opportunity together with @Nicoretti to take a look at your PR.
Nico and I are aware of some changes described in issue #181.
And we propose to wait until #181 is implemented before finalizing the current PR.

Nicoretti
Nicoretti approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@Nicoretti Nicoretti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ckunki
ckunki approved these changes Sep 25, 2024
View reviewed changes
.github/workflows/checks.yml Show resolved Hide resolved
exasol/toolbox/nox/_metrics.py Show resolved Hide resolved
@Jannis-Mittenzwei Jannis-Mittenzwei merged commit c922bc2 into main Sep 25, 2024
19 checks passed
@Jannis-Mittenzwei Jannis-Mittenzwei deleted the feature#74-add-security-linter-to-the-toolbox branch September 25, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

@ckunki ckunki ckunki approved these changes

Assignees

@Jannis-Mittenzwei Jannis-Mittenzwei

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Add security linter to the toolbox
3 participants
@Jannis-Mittenzwei @ckunki @Nicoretti