Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated actions/checkout to v4 #221

Merged
merged 10 commits into from
Jul 16, 2024

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented Jul 15, 2024

No description provided.

@ckunki ckunki self-assigned this Jul 15, 2024
kaklakariada
kaklakariada previously approved these changes Jul 15, 2024
Copy link
Member

@Nicoretti Nicoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, this change is not trivial due to the fact that the upload and download semantics have changed, affecting overwrites and resulting in different download URLs. With v4, if you push the same artifact name multiple times, it gets uploaded multiple times. However, the validity seems to depend on the last "overwrite." If one is unlucky, the wrong download URL will be used on the other end, resulting in broken or non-existing artifacts, etc.

@ckunki
Copy link
Contributor Author

ckunki commented Jul 15, 2024

Sadly, this change is not trivial due to the fact that the upload and download semantics have changed, affecting overwrites and resulting in different download URLs. With v4, if you push the same artifact name multiple times, it gets uploaded multiple times. However, the validity seems to depend on the last "overwrite." If one is unlucky, the wrong download URL will be used on the other end, resulting in broken or non-existing artifacts, etc.

Do you propose to switch back to v3 then?

@Nicoretti
Copy link
Member

Nicoretti commented Jul 16, 2024

@ckunki we also can push forward this pr, but then we likely need to change the upload and download strategy we are using right now. If this will be addressed in this PR to I'll happy to merge it!

kaklakariada
kaklakariada previously approved these changes Jul 16, 2024
@ckunki ckunki merged commit 440e0a9 into main Jul 16, 2024
15 checks passed
@ckunki ckunki deleted the refactoring/update_versions_of_github_actions branch July 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants