-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated actions/checkout to v4 #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, this change is not trivial due to the fact that the upload and download semantics have changed, affecting overwrites and resulting in different download URLs. With v4, if you push the same artifact name multiple times, it gets uploaded multiple times. However, the validity seems to depend on the last "overwrite." If one is unlucky, the wrong download URL will be used on the other end, resulting in broken or non-existing artifacts, etc.
Do you propose to switch back to v3 then? |
@ckunki we also can push forward this pr, but then we likely need to change the upload and download strategy we are using right now. If this will be addressed in this PR to I'll happy to merge it! |
No description provided.