add nox task to verify dependency declarations #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckunki
requested changes
Aug 21, 2024
Jannis-Mittenzwei
force-pushed
the
feature/#233-add-nox-task-to-verify-dependency-declarations
branch
from
756d4b8
to
9c33b61
Compare
Nicoretti
reviewed
Sep 3, 2024
…ify-dependency-declarations' into feature/#233-add-nox-task-to-verify-dependency-declarations # Conflicts: # exasol/toolbox/nox/_dependencies_check.py
Jannis-Mittenzwei
force-pushed
the
feature/#233-add-nox-task-to-verify-dependency-declarations
branch
from
1ad32ce
to
7b88101
Compare
ckunki
requested changes
Sep 10, 2024
ckunki
requested changes
Sep 23, 2024
Nicoretti
previously approved these changes
Sep 25, 2024
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
reviewed
Oct 18, 2024
Comment on lines
+27
to
+29
| def __init__(self, pyproject_toml: str): | ||
| self.illegal_dict: Dict[str, List[str]] = {} | ||
| self.content = pyproject_toml |
There was a problem hiding this comment.
after construction the class should be initialized properly
Comment on lines
+31
to
+70
| def parse(self) -> "Dependencies": | ||
| def source_filter(version) -> bool: | ||
| for f in self.ILLEGAL_DEPENDENCIES: | ||
| if f in version: | ||
| return True | ||
| return False | ||
|
|
||
| def extract_dependencies(section) -> List[str]: | ||
| dependencies = [] | ||
| for name, version in section.items(): | ||
| if source_filter(version): | ||
| dependencies.append(f"{name} = {version}") | ||
| return dependencies | ||
|
|
||
| illegal: Dict[str, List[str]] = {} | ||
| toml = tomlkit.loads(self.content) | ||
| poetry = toml.get("tool", {}).get("poetry", {}) | ||
|
|
||
| part = poetry.get("dependencies", {}) | ||
| dependencies_list = extract_dependencies(part) | ||
| if dependencies_list: | ||
| illegal["tool.poetry.dependencies"] = dependencies_list | ||
|
|
||
| part = poetry.get("dev", {}).get("dependencies", {}) | ||
| dependencies_list = extract_dependencies(part) | ||
| if dependencies_list: | ||
| illegal["tool.poetry.dev.dependencies"] = dependencies_list | ||
|
|
||
| part = poetry.get("group", {}) | ||
| for group, content in part.items(): | ||
| dependencies_list = extract_dependencies(content.get("dependencies", {})) | ||
| if dependencies_list: | ||
| illegal[f"tool.poetry.group.{group}.dependencies"] = dependencies_list | ||
|
|
||
| self.illegal_dict = illegal | ||
| return self | ||
|
|
||
| @property | ||
| def illegal(self) -> Dict[str, List[str]]: | ||
| return self.illegal_dict |
There was a problem hiding this comment.
Suggested change
| def parse(self) -> "Dependencies": | |
| def source_filter(version) -> bool: | |
| for f in self.ILLEGAL_DEPENDENCIES: | |
| if f in version: | |
| return True | |
| return False | |
| def extract_dependencies(section) -> List[str]: | |
| dependencies = [] | |
| for name, version in section.items(): | |
| if source_filter(version): | |
| dependencies.append(f"{name} = {version}") | |
| return dependencies | |
| illegal: Dict[str, List[str]] = {} | |
| toml = tomlkit.loads(self.content) | |
| poetry = toml.get("tool", {}).get("poetry", {}) | |
| part = poetry.get("dependencies", {}) | |
| dependencies_list = extract_dependencies(part) | |
| if dependencies_list: | |
| illegal["tool.poetry.dependencies"] = dependencies_list | |
| part = poetry.get("dev", {}).get("dependencies", {}) | |
| dependencies_list = extract_dependencies(part) | |
| if dependencies_list: | |
| illegal["tool.poetry.dev.dependencies"] = dependencies_list | |
| part = poetry.get("group", {}) | |
| for group, content in part.items(): | |
| dependencies_list = extract_dependencies(content.get("dependencies", {})) | |
| if dependencies_list: | |
| illegal[f"tool.poetry.group.{group}.dependencies"] = dependencies_list | |
| self.illegal_dict = illegal | |
| return self | |
| @property | |
| def illegal(self) -> Dict[str, List[str]]: | |
| return self.illegal_dict | |
| class Dependencies: | |
| def __init__(self, illegal: Dict[str, List[str]] | None): | |
| self._illegal = illegal or {} | |
| @staticmethod | |
| def parse(pyproject_toml: str) -> "Dependencies": | |
| def _source_filter(version) -> bool: | |
| ILLEGAL_SPECIFIERS = ['url', 'git', 'path'] | |
| return any( | |
| specifier in version | |
| for specifier in ILLEGAL_SPECIFIERS | |
| ) | |
| def _extract_dependencies(section) -> List[str]: | |
| dependencies = [] | |
| for name, version in section.items(): | |
| if _source_filter(version): | |
| dependencies.append(f"{name} = {version}") | |
| return dependencies | |
| illegal: Dict[str, List[str]] = {} | |
| toml = tomlkit.loads(pyproject_toml) | |
| poetry = toml.get("tool", {}).get("poetry", {}) | |
| part = poetry.get("dependencies", {}) | |
| dependencies_list = _extract_dependencies(part) | |
| if dependencies_list: | |
| illegal["tool.poetry.dependencies"] = dependencies_list | |
| part = poetry.get("dev", {}).get("dependencies", {}) | |
| dependencies_list = _extract_dependencies(part) | |
| if dependencies_list: | |
| illegal["tool.poetry.dev.dependencies"] = dependencies_list | |
| part = poetry.get("group", {}) | |
| for group, content in part.items(): | |
| dependencies_list = _extract_dependencies(content.get("dependencies", {})) | |
| if dependencies_list: | |
| illegal[f"tool.poetry.group.{group}.dependencies"] = dependencies_list | |
| return Dependencies(illegal) | |
| @property | |
| def illegal(self) -> Dict[str, List[str]]: | |
| return self._illegal |
| ) | ||
| def test_dependencies_check_report(toml, expected, capsys): | ||
| console = rich.console.Console() | ||
| dependencies = Dependencies(toml).parse() |
There was a problem hiding this comment.
Suggested change
| dependencies = Dependencies(toml).parse() | |
| dependencies = Dependencies.parse(toml) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #233