-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-security-linter-results-to-workflow-summary #254
base: main
Are you sure you want to change the base?
add-security-linter-results-to-workflow-summary #254
Conversation
@@ -15,8 +15,9 @@ | |||
Iterable, | |||
Tuple, | |||
) | |||
|
|||
from noxconfig import PROJECT_CONFIG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually we do not want to import from nox config except withint the noxfile.
(Just remove the default)
@@ -51,3 +51,4 @@ jobs: | |||
poetry run coverage report -- --format markdown >> $GITHUB_STEP_SUMMARY | |||
echo -e "\n\n# Static Code Analysis\n" >> $GITHUB_STEP_SUMMARY | |||
cat .lint.txt >> $GITHUB_STEP_SUMMARY | |||
poetry run tbx security pretty-print .security.json >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same should be added to the workflow templates.
closes #248