add-security-linter-results-to-workflow-summary #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
changed the title
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
reviewed
Oct 4, 2024
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
reviewed
Oct 18, 2024
Jannis-Mittenzwei
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Nicoretti
requested changes
Oct 24, 2024
| @@ -15,8 +15,9 @@ | |||
| Iterable, | |||
| Tuple, | |||
| ) | |||
|
|
|||
| from noxconfig import PROJECT_CONFIG | |||
There was a problem hiding this comment.
usually we do not want to import from nox config except withint the noxfile.
(Just remove the default)
Nicoretti
reviewed
Oct 24, 2024
| @@ -51,3 +51,4 @@ jobs: | |||
| poetry run coverage report -- --format markdown >> $GITHUB_STEP_SUMMARY | |||
| echo -e "\n\n# Static Code Analysis\n" >> $GITHUB_STEP_SUMMARY | |||
| cat .lint.txt >> $GITHUB_STEP_SUMMARY | |||
| poetry run tbx security pretty-print .security.json >> $GITHUB_STEP_SUMMARY | |||
There was a problem hiding this comment.
The same should be added to the workflow templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #248