Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: composite multi contact #3351

Merged
merged 4 commits into from
Jan 31, 2025
Merged

fix: composite multi contact #3351

merged 4 commits into from
Jan 31, 2025

Conversation

eonarheim
Copy link
Member

@eonarheim eonarheim commented Jan 31, 2025

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

This PR fixes and issue where composite colliders in the "together" strategy contacts were being resolved multiple times in the ArcadeSolver causing visual jitter/artifacts

@github-actions github-actions bot added the bug This issue describes undesirable, incorrect, or unexpected behavior label Jan 31, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2025

Deploying excaliburjs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4a2b97
Status:⚡️  Build in progress...

View logs

@eonarheim eonarheim merged commit 907972d into main Jan 31, 2025
5 of 7 checks passed
@eonarheim eonarheim deleted the fix/composite-multi-contact branch January 31, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue describes undesirable, incorrect, or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant