-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] feat: support state diagram #56
base: master
Are you sure you want to change the base?
[wip] feat: support state diagram #56
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0c9eb0c
to
396c8db
Compare
Awesome @igorwessel, we'll check soon! ❤️ |
396c8db
to
4bb3d0a
Compare
4bb3d0a
to
0a877f5
Compare
this code need to be refactor
0a877f5
to
b4969b3
Compare
@ad1992 Currently, I'm not sure how to create a "bound" for an example where we have N levels of deep layers between composite states. I've tried adding a groupid of ["first", "second", "third"] to all elements but it doesn't work well. Don't pay attention to the (state_end inner circle), I'm still working on it while I decipher the notes. (In PR preview is testcase: Composite states in deep layers) Gravacao.de.Tela.2024-05-03.as.20.18.39.movDo you have any suggestions? |
Unecessary checks if is cluster
…into feat/support-state-diagram
Apologies for the delayed response! I promise to review and get back to it this week |
@igorwessel probably something like 👇🏻 you mean ? (groups inside group).
|
Exactly what I wanted, looking at the output you brought I think I understood how I can have the same behavior. tks @ad1992 For all elements of group 1, there should be something: ["First"] I should reverse the order of the relationships, I had misunderstood the part of "ordered from deepest to shallowest." |
Awesome! |
Hi @igorwessel, just checking if this PR is ready from your end ? |
@ad1992 I had stopped because I was waiting for a release of mermaid (mermaid-js/mermaid#5503) to be able to link the edges correctly for each element. But with the release this PR is in the final stages, I just need to resolve a few things like:
|
I have asked for RC in the same PR, hoping we should be able to get the RC and use it to unblock |
@ad1992 Mermaid released version v11, but with some breaking-changes between all diagrams. I think it's better to separate this update into another PR. |
yes @igorwessel sounds good. In the meanwhile, I will work on upgrading the project to mermaid v11 |
Basic example:
Todo