Use public methods only when calling mailers. Fixes #457

excid3 · Jun 21, 2024 · 91547b8 · 91547b8
1 parent b1148c4
commit 91547b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ### Unreleased
 
+* Use `public_send` for Email delivery so it doesn't accidentally call private methods.
+
 ### 2.3.2
 
 * Set `:json` type on `:params` column with default to better integrate with ActiveRecord.

diff --git a/lib/noticed/delivery_methods/email.rb b/lib/noticed/delivery_methods/email.rb
@@ -7,7 +7,7 @@ def deliver
         mailer = fetch_constant(:mailer)
         email = evaluate_option(:method)
         args = evaluate_option(:args) || []
-        mail = mailer.with(params).send(email, *args)
+        mail = mailer.with(params).public_send(email, *args)
         (!!evaluate_option(:enqueue)) ? mail.deliver_later : mail.deliver_now
       end